hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2065) Fix NPE in DFSClient.getFileChecksum
Date Mon, 22 Aug 2011 10:47:29 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088600#comment-13088600
] 

Hadoop QA commented on HDFS-2065:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12483562/HDFS-2065-1.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1139//console

This message is automatically generated.

> Fix NPE in DFSClient.getFileChecksum
> ------------------------------------
>
>                 Key: HDFS-2065
>                 URL: https://issues.apache.org/jira/browse/HDFS-2065
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.23.0
>            Reporter: Bharath Mundlapudi
>            Assignee: Bharath Mundlapudi
>             Fix For: 0.23.0
>
>         Attachments: HDFS-2065-1.patch
>
>
> The following code can throw NPE if callGetBlockLocations returns null.
> If server returns null 
> {code}
>     List<LocatedBlock> locatedblocks
>         = callGetBlockLocations(namenode, src, 0, Long.MAX_VALUE).getLocatedBlocks();
> {code}
> The right fix for this is server should throw right exception.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message