hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2266) Add a Namesystem interface to avoid directly referring to FSNamesystem
Date Fri, 19 Aug 2011 16:46:27 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087793#comment-13087793
] 

Suresh Srinivas commented on HDFS-2266:
---------------------------------------

Good change.

Comments:
# SafeMode.java
#* Add InterfaceAudience.PRIVATE annotation. Same for Namesystem.java
#* "Check whether replication queues are populated." to "Check whether replication queues
are being populated." - Added being
#* I am not sure javadoc "Check and trigger safe mode" is clear enough
#* isInStartupSafeMode - javadoc could describe what startup safemode is
# Why not just use import DFSConfigKeys.* instead of expanding it to individual imports? Keeps
it brief.


> Add a Namesystem interface to avoid directly referring to FSNamesystem
> ----------------------------------------------------------------------
>
>                 Key: HDFS-2266
>                 URL: https://issues.apache.org/jira/browse/HDFS-2266
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h2266_20110817.patch, h2266_20110817b.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message