hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2265) Remove unnecessary BlockTokenSecretManager fields/methods from BlockManager
Date Wed, 17 Aug 2011 14:05:33 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086322#comment-13086322
] 

Uma Maheswara Rao G commented on HDFS-2265:
-------------------------------------------

Hi Nicholas,

I have gone through the chnages. 

I have one small comment here (This comment is not introduced by this patch)
 1) In TestBlockTokenWithDFS.java
   Since we touched this file, lets clean :-)
   Here looks not closed stream properly.
   {code}
     private void createFile(FileSystem fs, Path filename) throws IOException {
       FSDataOutputStream out = fs.create(filename);
       out.write(rawData);
       out.close();
     }
     {code}
  One more observation is many places in HDFS tests we used this kind of file creation 'private
APIs'.
  DFSTestUtil.java already has file creation APIs. can we move it to that util and use by
handling the streams?.

Other than that patch looks good to me.
+1

> Remove unnecessary BlockTokenSecretManager fields/methods from BlockManager
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-2265
>                 URL: https://issues.apache.org/jira/browse/HDFS-2265
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h2265_20110816.patch, h2265_20110816b.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message