hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-362) FSEditLog should not writes long and short as UTF8 and should not use ArrayWritable for writing non-array items
Date Fri, 26 Aug 2011 19:59:29 GMT

    [ https://issues.apache.org/jira/browse/HDFS-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13091989#comment-13091989
] 

Hadoop QA commented on HDFS-362:
--------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12491819/HDFS-362.2d.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these unit tests:

                  org.apache.hadoop.hdfs.server.datanode.TestReplicasMap
                  org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap
                  org.apache.hadoop.hdfs.TestDfsOverAvroRpc
                  org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1163//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1163//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1163//console

This message is automatically generated.

> FSEditLog should not writes long and short as UTF8 and should not use ArrayWritable for
writing non-array items
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-362
>                 URL: https://issues.apache.org/jira/browse/HDFS-362
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Uma Maheswara Rao G
>         Attachments: HDFS-362.1.patch, HDFS-362.2.patch, HDFS-362.2b.patch, HDFS-362.2c.patch,
HDFS-362.2d.patch, HDFS-362.2d.patch, HDFS-362.patch
>
>
> In FSEditLog, 
> - long and short are first converted to String and are further converted to UTF8
> - For some non-array items, it first create an ArrayWritable object to hold all the items
and then writes the ArrayWritable object.
> These result creating many intermediate objects which affects Namenode CPU performance
and Namenode restart.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message