hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2281) NPE in checkpoint during processIOError()
Date Tue, 30 Aug 2011 09:51:38 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093622#comment-13093622
] 

Uma Maheswara Rao G commented on HDFS-2281:
-------------------------------------------

 Hi Konstantin,

   Thanks a lot for taking a look on this patch.
   Below is the test-patch results

     [exec]     +1 @author. The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include  new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.
     [exec] 
     [exec]     +1 system test framework.  The patch passed system test framework compile.

When i ran the tests no failures observed because of this changes.

Thanks
Uma

> NPE in checkpoint during processIOError()
> -----------------------------------------
>
>                 Key: HDFS-2281
>                 URL: https://issues.apache.org/jira/browse/HDFS-2281
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.22.0
>            Reporter: Konstantin Shvachko
>            Assignee: Uma Maheswara Rao G
>             Fix For: 0.22.0
>
>         Attachments: BN-bug-NPE.txt, HDFS-2281.patch
>
>
> At the end of checkpoint BackupNode tries to convergeJournalSpool() and calls revertFileStreams().
The latter closes each file stream, and tries to rename the corresponding file to its permanent
location current/edits. If for any reason the rename fails processIOError() is called for
failed streams. processIOError() will try to close the stream again and will get NPE in EditLogFileOutputStream.close()
because bufCurrent was set to null by the previous close.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message