Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Thu, 7 Jul 2011 16:05:17 +0000 (UTC)
From: "Todd Lipcon (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <1571284865.7991.1310054717349.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <463470900.55765.1306838807767.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-2018) Move all journal stream management
 code into one place
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061403#comment-13061403 ] 

Todd Lipcon commented on HDFS-2018:
-----------------------------------

Hey Ivan/Jitendra. I'm taking a look at this patch, and while I really like the direction it's headed, I'd like to propose that we hold off on committing it until after HDFS-1073 is merged into trunk. My thinking is that we'd finish the remaining tasks on 1073 (per my email to general@ last night), merge it, and then keep the 1073 branch alive to finish the work related to HDFS-1580 and this JIRA.

My reasoning is that the 1073 merge is a blocker both for the NN HA work and for the 0.23 release. While it would be awesome to get the hooks in for BK in the same timeframe, I don't think it should be a release blocker, since it's truly a new feature.

Does that make sense? I'll try to review this in parallel while we get the remaining 1073 tasks done.

> Move all journal stream management code into one place
> ------------------------------------------------------
>
>                 Key: HDFS-2018
>                 URL: https://issues.apache.org/jira/browse/HDFS-2018
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: Edit log branch (HDFS-1073)
>
>         Attachments: HDFS-2018.diff, HDFS-2018.diff, HDFS-2018.diff, HDFS-2018.diff, HDFS-2018.diff, HDFS-2018.diff, HDFS-2018.diff, HDFS-2018.diff, HDFS-2018.diff
>
>
> Currently in the HDFS-1073 branch, the code for creating output streams is in FileJournalManager and the code for input streams is in the inspectors. This change does a number of things.
>   - Input and Output streams are now created by the JournalManager.
>   - FSImageStorageInspectors now deals with URIs when referring to edit logs
>   - Recovery of inprogress logs is performed by counting the number of transactions instead of looking at the length of the file.
> The patch for this applies on top of the HDFS-1073 branch + HDFS-2003 patch.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira