hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-2195) Refactor StorageDirectory to not be an non-static inner class
Date Thu, 28 Jul 2011 03:21:09 GMT

     [ https://issues.apache.org/jira/browse/HDFS-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Eli Collins updated HDFS-2195:
------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I've committed this. Thanks Todd!

> Refactor StorageDirectory to not be an non-static inner class
> -------------------------------------------------------------
>
>                 Key: HDFS-2195
>                 URL: https://issues.apache.org/jira/browse/HDFS-2195
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node, name-node
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hdfs-2195.txt, hdfs-2195.txt
>
>
> While working on HDFS-1073 I continually found it inconvenient that StorageDirectory
is a non-static inner class of Storage. This makes testing more complicated, and also has
unintuitive results, like {{sd.read()}} having side effects on a Storage object.
> I'd like to try to make it a static inner class so that these side effects are clearer
and it's easier to use in isolation.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message