hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2149) Move EditLogOp serialisation and deserialation into one place
Date Thu, 14 Jul 2011 18:10:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065429#comment-13065429
] 

Aaron T. Myers commented on HDFS-2149:
--------------------------------------

I also find the OEV code confusing. I think its implementation of the visitor pattern is slightly
different from what is usually done.

As for a benchmark, I'd recommend either using {{NNThroughputBenchmark}} or writing your own
custom micro-benchmark in the same vain as HDFS-1846.

> Move EditLogOp serialisation and deserialation into one place
> -------------------------------------------------------------
>
>                 Key: HDFS-2149
>                 URL: https://issues.apache.org/jira/browse/HDFS-2149
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 0.23.0
>
>         Attachments: HDFS-2149.diff
>
>
> On trunk serialisation of editlog ops is in FSEditLog#log* and deserialisation is in
FSEditLogOp.*Op . This improvement is to move the serialisation code into one place, i.e under
FSEditLogOp.*Op.
> This is part of HDFS-1580.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message