hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-1774) Small optimization in org.apache.hadoop.hdfs.server.datanode.FSDataset class.
Date Mon, 18 Jul 2011 18:57:57 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067214#comment-13067214

Hadoop QA commented on HDFS-1774:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision 1147980.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/962//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/962//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/962//console

This message is automatically generated.

> Small optimization in org.apache.hadoop.hdfs.server.datanode.FSDataset class.
> -----------------------------------------------------------------------------
>                 Key: HDFS-1774
>                 URL: https://issues.apache.org/jira/browse/HDFS-1774
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>             Fix For: 0.23.0
>         Attachments: HDFS-1774-1.patch, HDFS-1774-1.patch, HDFS-1774.patch
>  Inner class FSDir constructor is doing duplicate iterations over the listed files in
the passed directory. We can optimize this to single loop and also we can avoid isDirectory
check which will perform some native invocations. 
>   Consider a case: one directory has only one child directory and 10000 files. 
> 1) First loop will get the number of children directories.
> 2) if (numChildren > 0) , This condition will satisfy and again it will iterate 10001
times and also will check isDirectory.

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message