hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2195) Refactor StorageDirectory to not be an non-static inner class
Date Tue, 26 Jul 2011 21:37:09 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13071373#comment-13071373

Hadoop QA commented on HDFS-2195:

+1 overall.  Here are the results of testing the latest attachment 
  against trunk revision 1150960.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 9 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1027//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1027//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1027//console

This message is automatically generated.

> Refactor StorageDirectory to not be an non-static inner class
> -------------------------------------------------------------
>                 Key: HDFS-2195
>                 URL: https://issues.apache.org/jira/browse/HDFS-2195
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node, name-node
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hdfs-2195.txt, hdfs-2195.txt
> While working on HDFS-1073 I continually found it inconvenient that StorageDirectory
is a non-static inner class of Storage. This makes testing more complicated, and also has
unintuitive results, like {{sd.read()}} having side effects on a Storage object.
> I'd like to try to make it a static inner class so that these side effects are clearer
and it's easier to use in isolation.

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message