hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-1977) Stop using StringUtils.stringifyException()
Date Wed, 06 Jul 2011 23:09:16 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060904#comment-13060904

Hadoop QA commented on HDFS-1977:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision 1143147.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/884//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/884//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/884//console

This message is automatically generated.

> Stop using StringUtils.stringifyException()
> -------------------------------------------
>                 Key: HDFS-1977
>                 URL: https://issues.apache.org/jira/browse/HDFS-1977
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Joey Echeverria
>            Assignee: Bharath Mundlapudi
>            Priority: Minor
>         Attachments: HDFS-1977-1.patch, HDFS-1977-2.patch
> The old version of the logging APIs didn't support logging stack traces by passing exceptions
to the logging methods (e.g. Log.error()). A number of log statements make use of StringUtils.stringifyException()
to get around the old behavior. It would be nice if this could get cleaned up to make use
of the the logger's stack trace printing. This also gives users more control since you can
configure how the stack traces are written to the logs.

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message