hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ivan Kelly (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2149) Move EditLogOp serialisation and deserialation into one place
Date Fri, 15 Jul 2011 09:25:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065802#comment-13065802
] 

Ivan Kelly commented on HDFS-2149:
----------------------------------

REPOST from HDFS-1073:

HDFS-2149 will probably remove LogHeader completely. I plan to add a getVersion() call to
InputStreams and each stream will handle it's own metadata internally. So EditLogFileInputStream
will read it's version on creation, or first call to read etc. The input and output stream
will be packet based, so an input stream is basically an iterator over FSEditLogOp objects
and output stream is a sink for FSEditLogOp objects. I think the way I've implemented the
FSEditLogOp objects should avoid all extra copies and object creation. Whats more, there's
plenty to room to improve this by removing the creation of ArrayWritables and DeprecatedUTF8
objects and just write strings and arrays directly. 

> Move EditLogOp serialisation and deserialation into one place
> -------------------------------------------------------------
>
>                 Key: HDFS-2149
>                 URL: https://issues.apache.org/jira/browse/HDFS-2149
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 0.23.0
>
>         Attachments: HDFS-2149.diff
>
>
> On trunk serialisation of editlog ops is in FSEditLog#log* and deserialisation is in
FSEditLogOp.*Op . This improvement is to move the serialisation code into one place, i.e under
FSEditLogOp.*Op.
> This is part of HDFS-1580.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message