hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Plamen Jeliazkov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2116) Cleanup TestStreamFile and TestByteRangeInputStream
Date Mon, 18 Jul 2011 17:04:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067142#comment-13067142

Plamen Jeliazkov commented on HDFS-2116:

The only issue I see is in the release audit:

[ivy:resolve] :: problems summary ::
[ivy:resolve] :::: WARNINGS
[ivy:resolve] 		module not found: org.apache.hadoop#hadoop-common-test;0.23.0-SNAPSHOT
[ivy:resolve] 	==== apache-snapshot: tried
[ivy:resolve] 	  https://repository.apache.org/content/repositories/snapshots/org/apache/hadoop/hadoop-common-test/0.23.0-SNAPSHOT/hadoop-common-test-0.23.0-SNAPSHOT.pom
[ivy:resolve] 	  -- artifact org.apache.hadoop#hadoop-common-test;0.23.0-SNAPSHOT!hadoop-common-test.jar:
[ivy:resolve] 	  https://repository.apache.org/content/repositories/snapshots/org/apache/hadoop/hadoop-common-test/0.23.0-SNAPSHOT/hadoop-common-test-0.23.0-SNAPSHOT.jar
[ivy:resolve] 	==== maven2: tried
[ivy:resolve] 	  http://repo1.maven.org/maven2/org/apache/hadoop/hadoop-common-test/0.23.0-SNAPSHOT/hadoop-common-test-0.23.0-SNAPSHOT.pom
[ivy:resolve] 	  -- artifact org.apache.hadoop#hadoop-common-test;0.23.0-SNAPSHOT!hadoop-common-test.jar:
[ivy:resolve] 	  http://repo1.maven.org/maven2/org/apache/hadoop/hadoop-common-test/0.23.0-SNAPSHOT/hadoop-common-test-0.23.0-SNAPSHOT.jar
[ivy:resolve] 		::::::::::::::::::::::::::::::::::::::::::::::
[ivy:resolve] 		::          UNRESOLVED DEPENDENCIES         ::
[ivy:resolve] 		::::::::::::::::::::::::::::::::::::::::::::::
[ivy:resolve] 		:: org.apache.hadoop#hadoop-common-test;0.23.0-SNAPSHOT: not found
[ivy:resolve] 		::::::::::::::::::::::::::::::::::::::::::::::
[ivy:resolve] :::: ERRORS
[ivy:resolve] 	SERVER ERROR: Internal Server Error url=https://repository.apache.org/content/repositories/snapshots/org/apache/hadoop/hadoop-common-test/0.23.0-SNAPSHOT/hadoop-common-test-0.23.0-SNAPSHOT.pom
[ivy:resolve] 	SERVER ERROR: Service Temporarily Unavailable url=https://repository.apache.org/content/repositories/snapshots/org/apache/hadoop/hadoop-common-test/0.23.0-SNAPSHOT/hadoop-common-test-0.23.0-SNAPSHOT.jar

/grid/0/hudson/hudson-slave/workspace/PreCommit-HDFS-Build/trunk/build.xml:1957: impossible
to resolve dependencies:
	resolve failed - see output for details

Total time: 19 seconds

I am a little unclear how to resolve it though -- is my test fix causing a dependency issue?

TestByteRangeInputStream.java :
1) Of course.
2) Interesting, it appears as an issue on my Eclipse; I can certainly remove it though.
3) The original test printed MockURL's getMsg() and compared it to a hardcoded string. The
string returned by getMsg() was a combined string containing the URL string and the string
info returned from .openConnection.requestProperty("Range"). I tried to preserve the test
by testing for the URL and the byte info separately. I see there is no point in the URL check
though, I will remove it.

TestStreamFile.java :
1) I will need to look into what I am doing here; because without those warnings I will run
into other warnings stating that the Exception is not thrown and is therefore unneeded; and
when I delete the Exception it says I do need it; thus I went with a warning suppression;
I will remove it now though.
2) Of course.

> Cleanup TestStreamFile and TestByteRangeInputStream 
> ----------------------------------------------------
>                 Key: HDFS-2116
>                 URL: https://issues.apache.org/jira/browse/HDFS-2116
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>            Reporter: Eli Collins
>            Priority: Minor
>              Labels: newbie
>         Attachments: HDFS-2116.patch, HDFS-2116.patch
> TestStreamFile and TestByteRangeInputStream should use mockito. This would allow the
private URLOpener class to be removed from ByteRangeInputStream. 

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message