hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2161) Move utilities to DFSUtil
Date Tue, 19 Jul 2011 14:12:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067736#comment-13067736

Tsz Wo (Nicholas), SZE commented on HDFS-2161:

Hi Uma, thanks for reviewing my patch.  :)

I have created MAPREDUCE-2710 for updating {{JobSubmitter.printTokens(..)}}.

> 1. i did not see any big advantage by moving the random object ...

My main motivation is to clean up the code.  There are many {{Random}} objects floating around.
 In some cases, the object is not used, e.g. HftpFileSystem.  In some other cases, there are
two objects created in the same class, e.g. FSDataset.  I also believe there are synchronization
issue -- there are race conditions when two threads access the same Random object at the same
time.  Fortunately, it is very unlikely that why we have not observed the problem.

> 2. Now stringifyToken moved to DelegationTokenIdentifier ...

The one in MapReduce may have different fields.  So they may need different methods.

> Move utilities to DFSUtil
> -------------------------
>                 Key: HDFS-2161
>                 URL: https://issues.apache.org/jira/browse/HDFS-2161
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: balancer, data-node, hdfs client, name-node, security
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: h2161_20110718.patch
> Utilities include
> - {{createNamenode(..)}}, {{createClientDatanodeProtocolProxy(..)}};
> - {{stringifyToken(..)}}; and
> - {{Random}} object.

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message