hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2132) Potential resource leak in EditLogFileOutputStream.close
Date Wed, 06 Jul 2011 20:43:19 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060823#comment-13060823
] 

Todd Lipcon commented on HDFS-2132:
-----------------------------------

hrm, it doesn't look like bufReady should ever throw an IOE on close, right? it's just a memory
buffer.

But, fc.truncate() might throw an IOE - that seems like the more realistic case to worry about.
Maybe that would be a better fault to inject for the test?

> Potential resource leak in EditLogFileOutputStream.close
> --------------------------------------------------------
>
>                 Key: HDFS-2132
>                 URL: https://issues.apache.org/jira/browse/HDFS-2132
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.23.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>             Fix For: 0.23.0
>
>         Attachments: hdfs-2132.0.patch, hdfs-2132.1.patch
>
>
> {{EditLogFileOutputStream.close(...)}} sequentially closes a series of underlying resources.
If any of the calls to {{close()}} throw before the last one, the later resources will never
be closed.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message