hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-2197) Refactor RPC call implementations out of NameNode class
Date Fri, 29 Jul 2011 23:34:09 GMT

     [ https://issues.apache.org/jira/browse/HDFS-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Todd Lipcon updated HDFS-2197:

    Attachment: hdfs-2197.txt

First pass at this refactoring. I moved all of the protocol implementation methods and the
start/stop of the RPC server into a new NameNodeRPCServer class.

It involved a fair number of changes to unit tests which were calling these methods directly
on a NameNode instance. MiniDFSCluster now exposes a separate function to get a NamenodeProtocols
object -- I think this is a net win, since it makes it clear when unit tests are calling internal
methods (like nn.getFSImage()) vs methods which are accessible to clients via RPC (like mkdirs)

> Refactor RPC call implementations out of NameNode class
> -------------------------------------------------------
>                 Key: HDFS-2197
>                 URL: https://issues.apache.org/jira/browse/HDFS-2197
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hdfs-2197.txt
> For HA, the NameNode will gain a bit of a state machine, to be able to transition between
standby and active states. This would be cleaner in the code if the {{NameNode}} class were
just a container for various services, as discussed in HDFS-1974. It's also nice for testing,
where it would become easier to construct just the RPC handlers around a mock NameSystem,
with no HTTP server, for example.
> This JIRA is to move all of the protocol implementations out of {{NameNode}} into a separate
{{NameNodeRPCServer}} class.

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message