hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2108) Move datanode heartbeat handling to BlockManager
Date Thu, 28 Jul 2011 01:59:09 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072141#comment-13072141

Tsz Wo (Nicholas), SZE commented on HDFS-2108:

The failure of TestLeaseRenewer is not related to this.  There was somehow a mockito exception.
 I could not reproduce it.
Unfinished stubbing detected here:
-> at org.apache.hadoop.hdfs.TestLeaseRenewer.testThreadName(TestLeaseRenewer.java:143)

E.g. thenReturn() may be missing.
Examples of correct stubbing:
 1. missing thenReturn()
 2. although stubbed methods may return mocks, you cannot inline mock creation (mock()) call
inside a thenReturn method (see issue 53)

	at org.apache.hadoop.hdfs.TestLeaseRenewer.testThreadName(TestLeaseRenewer.java:143)

> Move datanode heartbeat handling to BlockManager
> ------------------------------------------------
>                 Key: HDFS-2108
>                 URL: https://issues.apache.org/jira/browse/HDFS-2108
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h2108_20110727.patch, h2108_20110727b.patch
> Logically, datanodes should heartbeat to block manager instead of name system.  Therefore,
we should move datanode heartbeat handling code to {{BlockManager}}.

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message