hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2116) Cleanup TestStreamFile and TestByteRangeInputStream
Date Thu, 21 Jul 2011 19:16:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069141#comment-13069141
] 

Hadoop QA commented on HDFS-2116:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12486889/HDFS-2116.patch
  against trunk revision 1148981.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 10 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The applied patch generated 24 javac compiler warnings (more than the trunk's
current 23 warnings).

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/991//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/991//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/991//console

This message is automatically generated.

> Cleanup TestStreamFile and TestByteRangeInputStream 
> ----------------------------------------------------
>
>                 Key: HDFS-2116
>                 URL: https://issues.apache.org/jira/browse/HDFS-2116
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>            Reporter: Eli Collins
>            Priority: Minor
>              Labels: newbie
>         Attachments: HDFS-2116.patch, HDFS-2116.patch, HDFS-2116.patch
>
>
> TestStreamFile and TestByteRangeInputStream should use mockito. This would allow the
private URLOpener class to be removed from ByteRangeInputStream. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message