Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Mon, 6 Jun 2011 15:08:59 +0000 (UTC)
From: "Daryn Sharp (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <737100366.652.1307372939120.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1321652620.68068.1307162687352.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-2034) length in getBlockRange becomes -ve
 when reading only from currently being written blk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044900#comment-13044900 ] 

Daryn Sharp commented on HDFS-2034:
-----------------------------------

* I'd suggest changing {{"lastblkcomplete but read past that"}} to something more grammatically correct (I'm not the police!) like {{"can't read past last completed block"}}.

* There's an assertion for reading past the last *completed* block, but not for reading past the last *located* block?

* I found the names of the booleans to not be clear at face value.  Ie. I couldn't tell what they meant if I didn't see the assignment.

For your consideration, maybe something like this with a sprinkling of comments:
{code}
if (locatedBlocks.isLastBlockComplete())
  assert(!readOffsetPastCompletedBlock) : "can't read past last completed block";

if (!readOffsetPastCompletedBlock) {
  if (readLengthPastCompletedBlock) {
    length = locatedBlocks.getFileLength() - offset;
  }
  blocks = getFinalizedBlockRange(offset, length);
}
if (readOffsetPastCompletedBlock) {
  Block lastBlock = locatedBlocks.getLastLocatedBlock();
  long lastBlockEndOffset = lastBlock.getStartOffset() + lastBlock.getBlockSize();
  assert(offset < lastBlockEndOffset) : "can't read past last located block";
  blocks.add(lastLocatedBlock);
}
{code}

> length in getBlockRange becomes -ve when reading only from currently being written blk
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-2034
>                 URL: https://issues.apache.org/jira/browse/HDFS-2034
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: John George
>            Assignee: John George
>            Priority: Minor
>         Attachments: HDFS-2034.patch
>
>
> This came up during HDFS-1907. Posting an example that Todd posted in HDFS-1907 that brought out this issue.
> {quote}
> Here's an example sequence to describe what I mean:
> 1. open file, write one and a half blocks
> 2. call hflush
> 3. another reader asks for the first byte of the second block
> {quote}
> In this case since offset is greater than the completed block length, the math in getBlockRange() of DFSInputStreamer.java will set "length" to negative.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira