Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Tue, 21 Jun 2011 18:35:47 +0000 (UTC)
From: "Tsz Wo (Nicholas), SZE (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <524464143.25663.1308681347941.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1224488143.982.1300116571108.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-1753) Resource Leak in
 org.apache.hadoop.hdfs.server.namenode.StreamFile
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052748#comment-13052748 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-1753:
----------------------------------------------

{code}
+      in.close();
+      in = null;
+      os.close();
+      os = null;
+      dfs.close();
+      dfs = null;
{code}
It seems the code above is not needed since they will be closed in the finally-block.  No?

> Resource Leak in org.apache.hadoop.hdfs.server.namenode.StreamFile
> ------------------------------------------------------------------
>
>                 Key: HDFS-1753
>                 URL: https://issues.apache.org/jira/browse/HDFS-1753
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>            Priority: Minor
>         Attachments: HDFS-1753.1.patch, HDFS-1753.2.patch, HDFS-1753.patch
>
>
> In doGet Method, 
> final DFSInputStream in = dfs.open(filename);
> final long fileLen = in.getFileLength();
> OutputStream os = response.getOutputStream(); 
> Here this lines are present at out side of the try block.
> If response.getOutputStream() throws any exception then DFSInputStream will not be closed.So, better to move response.getOutputStream() into try block.
>  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira