Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Wed, 8 Jun 2011 00:31:59 +0000 (UTC)
From: "Todd Lipcon (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <442304312.1890.1307493119084.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1444662485.45737.1306428227417.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-2003) Separate FSEditLog reading logic
 from editLog memory state building logic
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045721#comment-13045721 ] 

Todd Lipcon commented on HDFS-2003:
-----------------------------------

Did a self-review by going through the diff with the old code on the left and the new Op classes on the right. Two small notes, one of which is a real bug:

- AddCloseOp has the following problem: in the old code, it would call fsNamesys.adjustReplication(), and then the adjusted replication would be passed to the readBlocks call. In the new code, the *unadjusted* replication is passed. So, the blocks end up with the wrong replication count.
- We should rename {{SetGenstampOp.lw}} to something more meaningful (perhaps {{genStamp}})


> Separate FSEditLog reading logic from editLog memory state building logic
> -------------------------------------------------------------------------
>
>                 Key: HDFS-2003
>                 URL: https://issues.apache.org/jira/browse/HDFS-2003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: Edit log branch (HDFS-1073)
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: Edit log branch (HDFS-1073)
>
>         Attachments: 2003-delta.txt, HDFS-2003.diff, HDFS-2003.diff, HDFS-2003.diff, HDFS-2003.diff, HDFS-2003.diff, hdfs-2003.txt, hdfs-2003.txt
>
>
> Currently FSEditLogLoader has code for reading from an InputStream interleaved with code which updates the FSNameSystem and FSDirectory. This makes it difficult to read an edit log without having a whole load of other object initialised, which is problematic if you want to do things like count how many transactions are in a file etc. 
> This patch separates the reading of the stream and the building of the memory state. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira