Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 58DF8639E for ; Mon, 27 Jun 2011 00:14:09 +0000 (UTC) Received: (qmail 37045 invoked by uid 500); 27 Jun 2011 00:14:09 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 36984 invoked by uid 500); 27 Jun 2011 00:14:08 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 36971 invoked by uid 99); 27 Jun 2011 00:14:08 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Jun 2011 00:14:08 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Jun 2011 00:14:07 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 6A755432875 for ; Mon, 27 Jun 2011 00:13:47 +0000 (UTC) Date: Mon, 27 Jun 2011 00:13:47 +0000 (UTC) From: "Jim Plush (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <397057087.42236.1309133627432.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (HDFS-979) FSImage should specify which dirs are missing when refusing to come up MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Plush updated HDFS-979: --------------------------- Attachment: HDFS-979-take2.txt Updated to use a StringBuilder in the loop after complaints from Findbugs report. > FSImage should specify which dirs are missing when refusing to come up > ---------------------------------------------------------------------- > > Key: HDFS-979 > URL: https://issues.apache.org/jira/browse/HDFS-979 > Project: Hadoop HDFS > Issue Type: Improvement > Components: name-node > Affects Versions: 0.22.0 > Reporter: Steve Loughran > Assignee: Jim Plush > Priority: Minor > Fix For: 0.23.0 > > Attachments: HDFS-979-take1.txt, HDFS-979-take2.txt > > > When {{FSImage}} can't come up as either it has no data or edit dirs, it tells me this > {code} > java.io.IOException: All specified directories are not accessible or do not exist. > {code} > What it doesn't do is say which of the two attributes are missing. This would be beneficial to anyone trying to track down the problem. Also, I don't think the message is correct. It's bailing out because dataDirs.size() == 0 || editsDirs.size() == 0 , because a list is empty -not because the dirs aren't there, as there hasn't been any validation yet. > More useful would be > # Explicit mention of which attributes are null > # Declare that this is because they are not in the config -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira