Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Fri, 10 Jun 2011 23:18:59 +0000 (UTC)
From: "Todd Lipcon (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <298504571.12719.1307747939232.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (HDFS-2058) DataTransfer Protocol using protobufs
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HDFS-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HDFS-2058:
------------------------------

    Attachment: hdfs-2058.txt

Attached new patch.

bq. Name ProtoUtil.java HDFSProtoUtil.java
Fixed (did HdfsProtoUtil for consistency with other classes in that package)

bq. With change in build.xml, do you still need to add generated file?

Yes, I provided the ant target for convenience, but I still think it's too painful to make all developers get protoc set up in their environment. It's hard enough for new contributors to get going on Hadoop, and if we make them install some native toolchain they aren't likely to have, it's even worse.


As for the other comments, I agree they could be done separately. Regarding the @Test(expected=...) pattern, I find it problematic since I want to only be sure that the exception is thrown at that one spot in the test, and not earlier or later than it's supposed to be.


> DataTransfer Protocol using protobufs
> -------------------------------------
>
>                 Key: HDFS-2058
>                 URL: https://issues.apache.org/jira/browse/HDFS-2058
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.23.0
>
>         Attachments: HDFS-2058.patch, hdfs-2058.txt, hdfs-2058.txt, hdfs-2058.txt, hdfs-2058.txt, hdfs-2058.txt
>
>
> We've been talking about this for a long time... would be nice to use something like protobufs or Thrift for some of our wire protocols.
> I knocked together a prototype of DataTransferProtocol on top of proto bufs that seems to work.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira