Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C49A0683A for ; Wed, 22 Jun 2011 07:33:19 +0000 (UTC) Received: (qmail 26838 invoked by uid 500); 22 Jun 2011 07:33:17 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 24071 invoked by uid 500); 22 Jun 2011 07:33:10 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 24061 invoked by uid 99); 22 Jun 2011 07:33:08 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Jun 2011 07:33:08 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Jun 2011 07:33:07 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 600FA4288C8 for ; Wed, 22 Jun 2011 07:32:47 +0000 (UTC) Date: Wed, 22 Jun 2011 07:32:47 +0000 (UTC) From: "Aaron T. Myers (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <24809195.27685.1308727967389.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (HDFS-49) MiniDFSCluster.stopDataNode will always shut down a node in the cluster if a matching name is not found MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aaron T. Myers updated HDFS-49: ------------------------------- Labels: newbie (was: ) > MiniDFSCluster.stopDataNode will always shut down a node in the cluster if a matching name is not found > ------------------------------------------------------------------------------------------------------- > > Key: HDFS-49 > URL: https://issues.apache.org/jira/browse/HDFS-49 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Steve Loughran > Priority: Minor > Labels: newbie > > The stopDataNode method will shut down the last node in the list of nodes, if one matching a specific name is not found > This is possibly not what was intended. Better to return false or fail in some other manner if the named node was not located > synchronized boolean stopDataNode(String name) { > int i; > for (i = 0; i < dataNodes.size(); i++) { > DataNode dn = dataNodes.get(i).datanode; > if (dn.dnRegistration.getName().equals(name)) { > break; > } > } > return stopDataNode(i); > } -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira