Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 16C466D2D for ; Thu, 30 Jun 2011 17:38:53 +0000 (UTC) Received: (qmail 69776 invoked by uid 500); 30 Jun 2011 17:38:53 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 69632 invoked by uid 500); 30 Jun 2011 17:38:52 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 69618 invoked by uid 99); 30 Jun 2011 17:38:52 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Jun 2011 17:38:52 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Jun 2011 17:38:49 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 1159E43CB32 for ; Thu, 30 Jun 2011 17:38:29 +0000 (UTC) Date: Thu, 30 Jun 2011 17:38:29 +0000 (UTC) From: "Eli Collins (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <2087880101.6101.1309455509067.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1224488143.982.1300116571108.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (HDFS-1753) Resource Leak in org.apache.hadoop.hdfs.server.namenode.StreamFile MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eli Collins updated HDFS-1753: ------------------------------ Attachment: HDFS-1753.4.patch Minor update to last patch. > Resource Leak in org.apache.hadoop.hdfs.server.namenode.StreamFile > ------------------------------------------------------------------ > > Key: HDFS-1753 > URL: https://issues.apache.org/jira/browse/HDFS-1753 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node > Reporter: Uma Maheswara Rao G > Assignee: Uma Maheswara Rao G > Priority: Minor > Attachments: HDFS-1753.1.patch, HDFS-1753.2.patch, HDFS-1753.3.patch, HDFS-1753.4.patch, HDFS-1753.patch > > > In doGet Method, > final DFSInputStream in = dfs.open(filename); > final long fileLen = in.getFileLength(); > OutputStream os = response.getOutputStream(); > Here this lines are present at out side of the try block. > If response.getOutputStream() throws any exception then DFSInputStream will not be closed.So, better to move response.getOutputStream() into try block. > -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira