Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Wed, 8 Jun 2011 00:31:58 +0000 (UTC)
From: "Eli Collins (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <1674466862.1885.1307493118951.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1891142178.2392.1307401678992.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-2040) Only build libhdfs if a flag is
 passed
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-2040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045720#comment-13045720 ] 

Eli Collins commented on HDFS-2040:
-----------------------------------

bq. Is there another patch to remove ${build.platform} from the c++ library build? 

Nope.

bq. Otherwise ${build.platform} should be preserved.

Why? c++/lib is a link to c++/${build.platform}/lib, the idea for this link is to not have to worry about the build.platform in all the places we want to point to the c++ lib.

> Only build libhdfs if a flag is passed
> --------------------------------------
>
>                 Key: HDFS-2040
>                 URL: https://issues.apache.org/jira/browse/HDFS-2040
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 0.23.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: hdfs-2040-1.patch
>
>
> In HDFS-2022 we made ant binary build libhdfs unconditionally, this is a pain for users who now need to get the native toolchain working to create a tarball to test a change, and inconsistent with common and MR (see MAPREDUCE-2559) which only build native code if a flag is passed. Let's revert to the previous behavior of requiring -Dlibhdfs be passed at build time. We could also create a new ant target that doesn't build the native code, however restoring the old behavior seems simplest.  
>   

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira