Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 918634D0B for ; Fri, 10 Jun 2011 17:50:20 +0000 (UTC) Received: (qmail 70678 invoked by uid 500); 10 Jun 2011 17:50:20 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 70646 invoked by uid 500); 10 Jun 2011 17:50:20 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 70635 invoked by uid 99); 10 Jun 2011 17:50:20 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Jun 2011 17:50:20 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Jun 2011 17:50:19 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 6E84C10DDF4 for ; Fri, 10 Jun 2011 17:49:59 +0000 (UTC) Date: Fri, 10 Jun 2011 17:49:59 +0000 (UTC) From: "Aaron T. Myers (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <1652428852.11374.1307728199449.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1211673242.2423.1307402279195.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HDFS-2041) Some mtimes and atimes are lost when edit logs are replayed MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047325#comment-13047325 ] Aaron T. Myers commented on HDFS-2041: -------------------------------------- +1, the change looks good to me, Todd. Great find. Thanks also for removing the vestigial {{runCommand}} from {{TestHDFSConcat}}. > Some mtimes and atimes are lost when edit logs are replayed > ----------------------------------------------------------- > > Key: HDFS-2041 > URL: https://issues.apache.org/jira/browse/HDFS-2041 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 0.22.0 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Fix For: 0.23.0 > > Attachments: hdfs-2041.txt, hdfs-2041.txt > > > The refactoring in HDFS-2003 allowed findbugs to expose two potential bugs: > - the atime field logged with OP_MKDIR is unused > - the timestamp field logged with OP_CONCAT_DELETE is unused > The concat issue is definitely real. The atime for MKDIR might always be identical to mtime in that case, in which case it could be ignored. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira