Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ED1D266FF for ; Sat, 4 Jun 2011 01:37:30 +0000 (UTC) Received: (qmail 76194 invoked by uid 500); 4 Jun 2011 01:37:30 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 76155 invoked by uid 500); 4 Jun 2011 01:37:30 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 76147 invoked by uid 99); 4 Jun 2011 01:37:30 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Jun 2011 01:37:30 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Jun 2011 01:37:28 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 691A2E160C for ; Sat, 4 Jun 2011 01:36:47 +0000 (UTC) Date: Sat, 4 Jun 2011 01:36:47 +0000 (UTC) From: "Roman Shaposhnik (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <1577621486.67796.1307151407426.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <377280337.6997.1297310757476.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (HDFS-1619) Does libhdfs really need to depend on AC_TYPE_INT16_T, AC_TYPE_INT32_T, AC_TYPE_INT64_T and AC_TYPE_UINT16_T ? MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Shaposhnik updated HDFS-1619: ----------------------------------- Attachment: HDFS-1619.patch.txt This trivial patch bites the bullet and removes the dependency on newer autoconf and on AC_TYPE_INTXX macros. The logic here is this -- on all platforms with conformant C99 compilers these macros are useless anyway, on platforms where C99 compiler is NOT available libhdfs is unlikely to compile even when these macros are present. > Does libhdfs really need to depend on AC_TYPE_INT16_T, AC_TYPE_INT32_T, AC_TYPE_INT64_T and AC_TYPE_UINT16_T ? > -------------------------------------------------------------------------------------------------------------- > > Key: HDFS-1619 > URL: https://issues.apache.org/jira/browse/HDFS-1619 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Roman Shaposhnik > Assignee: Konstantin Shvachko > Attachments: HDFS-1619.patch.txt > > > Currently configure.ac uses AC_TYPE_INT16_T, AC_TYPE_INT32_T, AC_TYPE_INT64_T and AC_TYPE_UINT16_T and thus requires autoconf 2.61 or higher. > This prevents using it on such platforms as CentOS/RHEL 5.4 and 5.5. Given that those are pretty popular and also given that it is really difficult to find a platform > these days that doesn't natively define intXX_t types I'm curious as to whether we can simply remove those macros or perhaps fail ONLY if we happen to be on such > a platform. > Here's a link to GNU autoconf docs for your reference: > http://www.gnu.org/software/hello/manual/autoconf/Particular-Types.html -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira