Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Thu, 23 Jun 2011 19:03:47 +0000 (UTC)
From: "Bharath Mundlapudi (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <1000984494.34276.1308855827556.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1271780704.23333.1308632387413.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-2092) Remove configuration object
 reference in DFSClient
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054037#comment-13054037 ] 

Bharath Mundlapudi commented on HDFS-2092:
------------------------------------------

I have moved uMask back to DFSClient as it was before instead of creating at the construction of DFSClient.Conf. Typically, Conf should be created once and should be sent to FileSystem.get. 

Like,
{code}
conf = new Configuration();
... //set conf related key, values here
fs = FileSystem.get(conf); 
{code}

But someone can do the following today:

{code}
conf = new Configuration();
... //set conf related key, values here
fs = FileSystem.get(conf); 
//set somemore or change the conf key, values here.
{code}

Clearly, this shouldn't be allowed. Today, conf is used as a context. It should be set once. If we want to change the conf then close the filesystem and re-init the conf.

I will fix the uMask related changes in an another JIRA since this requires some refactoring. 


> Remove configuration object reference in DFSClient
> --------------------------------------------------
>
>                 Key: HDFS-2092
>                 URL: https://issues.apache.org/jira/browse/HDFS-2092
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs client
>    Affects Versions: 0.23.0
>            Reporter: Bharath Mundlapudi
>            Assignee: Bharath Mundlapudi
>             Fix For: 0.23.0
>
>         Attachments: HDFS-2092-1.patch, HDFS-2092-2.patch
>
>
> At present, DFSClient stores reference to configuration object. Since, these configuration objects are pretty big at times can blot the processes which has multiple DFSClient objects like in TaskTracker. This is an attempt to remove the reference of conf object in DFSClient. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira