hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2110) Cleanup StreamFile#sendPartialData
Date Tue, 28 Jun 2011 04:38:17 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056290#comment-13056290
] 

Aaron T. Myers commented on HDFS-2110:
--------------------------------------

Two tiny nits, otherwise +1:

# In java docs, put a blank line between method descriptions and the beginning of the parameter/return/throws
list. You did this a little inconsistently in this patch.
# In {{StreamFile}}, the static references  to {{StreamFile.copyFromOffset(...)}} need not
explicitly specify the class.

> Cleanup StreamFile#sendPartialData
> ----------------------------------
>
>                 Key: HDFS-2110
>                 URL: https://issues.apache.org/jira/browse/HDFS-2110
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: hdfs-2110-1.patch
>
>
> StreamFile#sendPartialData can be cleaned up, has some System.out.printlns, no javadoc,
and the byte copying method should be pulled out to IOUtils. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message