hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2110) Cleanup StreamFile#sendPartialData
Date Tue, 28 Jun 2011 05:40:17 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056325#comment-13056325
] 

Hadoop QA commented on HDFS-2110:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12484393/hdfs-2110-1.patch
  against trunk revision 1140030.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The patch appears to cause tar ant target to fail.

    -1 findbugs.  The patch appears to cause Findbugs (version 1.3.9) to fail.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these core unit tests:


    -1 contrib tests.  The patch failed contrib unit tests.

    -1 system test framework.  The patch failed system test framework compile.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/856//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/856//console

This message is automatically generated.

> Cleanup StreamFile#sendPartialData
> ----------------------------------
>
>                 Key: HDFS-2110
>                 URL: https://issues.apache.org/jira/browse/HDFS-2110
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: hdfs-2110-1.patch
>
>
> StreamFile#sendPartialData can be cleaned up, has some System.out.printlns, no javadoc,
and the byte copying method should be pulled out to IOUtils. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message