hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-1787) "Not enough xcievers" error should propagate to client
Date Wed, 01 Jun 2011 00:05:47 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041901#comment-13041901

Tsz Wo (Nicholas), SZE commented on HDFS-1787:

- Why {{DFSOutputStream.internalDNErrors}} is an {{AtomicInteger}} but {{DFSInputStream.internalDNErrors}}
is an {{int}}?
- {{BlockReader.maxTransfersErrors}} is not used.
- What if {{Text.readString(..)}} throws an exception?
+      } else if (status == Status.ERROR)  {
+        String errmsg = Text.readString(in);
+        throw new InternalDataNodeException("Got error on read due to "
- It is better to add a catch-block for {{InternalDataNodeException}}.
     } catch (Throwable t) {
+      // Special case where we transfer max transfers error information to client.
+      try {
+        if (t instanceof InternalDataNodeException) {
+          // send error message.
- new public methods need javadoc.
- Please use junit 4.
- Please don't make white space change here for easing the review.

> "Not enough xcievers" error should propagate to client
> ------------------------------------------------------
>                 Key: HDFS-1787
>                 URL: https://issues.apache.org/jira/browse/HDFS-1787
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Jonathan Hsieh
>              Labels: newbie
>             Fix For: 0.23.0
>         Attachments: hdfs-1787.2.patch, hdfs-1787.3.patch, hdfs-1787.3.patch, hdfs-1787.patch
> We find that users often run into the default transceiver limits in the DN. Putting aside
the inherent issues with xceiver threads, it would be nice if the "xceiver limit exceeded"
error propagated to the client. Currently, clients simply see an EOFException which is hard
to interpret, and have to go slogging through DN logs to find the underlying issue.
> The data transfer protocol should be extended to either have a special error code for
"not enough xceivers" or should have some error code for generic errors with which a string
can be attached and propagated.

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message