hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-1969) Running rollback on new-version namenode destroys namespace
Date Fri, 03 Jun 2011 18:41:47 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043956#comment-13043956
] 

Eli Collins commented on HDFS-1969:
-----------------------------------

Todd, I agree that Konst's suggestion should be addressed in a separate jira, let's file one
for that. Thanks for attempting it here.

In NNStorage would the imageDigest ever be null now that we first check the layout version?
The comment may be more clear if something like "Only write this field if writing an newer
version file that supports image digests". Didn't know where -26 came from.

Wrt the precondition, in this scenario we typically throw an AssertionError right? These are
thrown when {{assert}}s are not enabled. If Precconditions are better how about filing a separate
jira to replace our use of AssertionError with Preconditions so we're consistent throughout
the project?

Core change and tests looks great btw.

> Running rollback on new-version namenode destroys namespace
> -----------------------------------------------------------
>
>                 Key: HDFS-1969
>                 URL: https://issues.apache.org/jira/browse/HDFS-1969
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Blocker
>             Fix For: 0.22.0
>
>         Attachments: hdfs-1969.txt, hdfs-1969.txt
>
>
> The following sequence leaves the namespace in an inconsistent/broken state:
> - format NN using 0.20 (or any prior release, probably)
> - run hdfs namenode -upgrade on 0.22. ^C the NN once it comes up.
> - run hdfs namenode -rollback on 0.22  (this should fail but doesn't!)
> This leaves the name directory in a state such that the version file claims it's an 0.20
namespace, but the fsimage is in 0.22 format. It then crashes when trying to start up.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message