hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-1619) Does libhdfs really need to depend on AC_TYPE_INT16_T, AC_TYPE_INT32_T, AC_TYPE_INT64_T and AC_TYPE_UINT16_T ?
Date Sat, 04 Jun 2011 03:32:47 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044181#comment-13044181
] 

Eli Collins commented on HDFS-1619:
-----------------------------------

bq. The idea behind AC_PROG_CC_C99 is to try and ask C compiler be C99 compliant and we definitely
have to do that if for nothing else just to make sure that #include <stdint.h> alway
works

AC_PROG_CC_C99 tries to enable c99 mode on the compiler (via CC), we don't need to do that
as we don't use c99 mode, we just require some c99 headers be present. Not sure how to tell
autoconf you require these headers w/o telling it to try to enable c99 mode by default. Using
AC_PROG_CC_C99 is fine (we could legitimately start using c99 features in libhdfs and fuse-dfs),
just saying we can remove these AC_* type defines w/o defining AC_PROG_CC_C99.

> Does libhdfs really need to depend on AC_TYPE_INT16_T, AC_TYPE_INT32_T, AC_TYPE_INT64_T
and AC_TYPE_UINT16_T ?
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1619
>                 URL: https://issues.apache.org/jira/browse/HDFS-1619
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Roman Shaposhnik
>            Assignee: Konstantin Shvachko
>         Attachments: HDFS-1619.patch.txt
>
>
> Currently configure.ac uses AC_TYPE_INT16_T, AC_TYPE_INT32_T, AC_TYPE_INT64_T and AC_TYPE_UINT16_T
and thus requires autoconf 2.61 or higher. 
> This prevents using it on such platforms as CentOS/RHEL 5.4 and 5.5. Given that those
are pretty popular and also given that it is really difficult to find a platform
> these days that doesn't natively define  intXX_t types I'm curious as to whether we can
simply remove those macros or perhaps fail ONLY if we happen to be on such
> a platform. 
> Here's a link to GNU autoconf docs for your reference:
>     http://www.gnu.org/software/hello/manual/autoconf/Particular-Types.html

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message