hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roman Shaposhnik (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-1619) Does libhdfs really need to depend on AC_TYPE_INT16_T, AC_TYPE_INT32_T, AC_TYPE_INT64_T and AC_TYPE_UINT16_T ?
Date Sat, 04 Jun 2011 03:19:47 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044177#comment-13044177
] 

Roman Shaposhnik commented on HDFS-1619:
----------------------------------------

||| Also note that fuse-dfs is AC_PREREQ(2.52), no reason libhdfs needs to be 2.61.

I don't think I follow your logic here. Currently libhdfs HAS to be 2.61 because it uses AC_TYPE_INTxx
macros.

||| We don't need to set AC_PROG_CC_C99 because we don't actually use any c99 features in
libhdfs.

It is a bit confusing for me to read this statement since you then confirm that stdint.h is
included. stdint.h is a C99 feature. In fact,
unless I'm missing some kind of a macro in libhdfs' configure.ac we HAVE to introduce AC_PROG_CC_C99
for it to
be properly compiled. The idea behind AC_PROG_CC_C99 is to try and ask C compiler be C99 compliant
and we definitely
have to do that if for nothing else just to make sure that #include <stdint.h> alway
works. At that point we can completely
ditch AC_TYPE_INTxx macros just as you mentioned.

Makes sense?

> Does libhdfs really need to depend on AC_TYPE_INT16_T, AC_TYPE_INT32_T, AC_TYPE_INT64_T
and AC_TYPE_UINT16_T ?
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1619
>                 URL: https://issues.apache.org/jira/browse/HDFS-1619
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Roman Shaposhnik
>            Assignee: Konstantin Shvachko
>         Attachments: HDFS-1619.patch.txt
>
>
> Currently configure.ac uses AC_TYPE_INT16_T, AC_TYPE_INT32_T, AC_TYPE_INT64_T and AC_TYPE_UINT16_T
and thus requires autoconf 2.61 or higher. 
> This prevents using it on such platforms as CentOS/RHEL 5.4 and 5.5. Given that those
are pretty popular and also given that it is really difficult to find a platform
> these days that doesn't natively define  intXX_t types I'm curious as to whether we can
simply remove those macros or perhaps fail ONLY if we happen to be on such
> a platform. 
> Here's a link to GNU autoconf docs for your reference:
>     http://www.gnu.org/software/hello/manual/autoconf/Particular-Types.html

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message