hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2110) Some StreamFile and ByteRangeInputStream cleanup
Date Tue, 28 Jun 2011 07:14:17 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056355#comment-13056355
] 

Aaron T. Myers commented on HDFS-2110:
--------------------------------------

A few tiny formatting nits, otherwise +1:

# "{{resolvedURL.getURL() == null? originalURL: resolvedURL}}" - put spaces before "?" and
":"
# "{{filelength = cl == null ? -1: Long.parseLong(cl)}}" - space before ":"
# "{{throw new IOException("HTTP_PARTIAL expected, received "+respCode)}}" - spaces around
"\+"
# "{{throw new IOException("HTTP_OK expected, received "+respCode)}}" - spaces around "\+"
# "{{"HTTP_OK expected, received 206"}}" - replace "206" with "HTTP_PARTIAL" as in the other
messages.

> Some StreamFile and ByteRangeInputStream cleanup
> ------------------------------------------------
>
>                 Key: HDFS-2110
>                 URL: https://issues.apache.org/jira/browse/HDFS-2110
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: hdfs-2110-1.patch, hdfs-2110-2.patch
>
>
> StreamFile#sendPartialData can be cleaned up, has some System.out.printlns, no javadoc,
and the byte copying method should be pulled out to IOUtils. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message