hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Foley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2019) Fix all the places where Java method File.list is used with FileUtil.list API
Date Fri, 03 Jun 2011 21:34:47 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044071#comment-13044071
] 

Matt Foley commented on HDFS-2019:
----------------------------------

Since this issue can't pass patch-test until HADOOP-7342 is committed, I ran test-patch locally:

     [exec] -1 overall.  
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified
tests.
     [exec]                         Please justify why no new tests are needed for this patch.
     [exec]                         Also please list what manual steps were performed to verify
this patch.
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.
     [exec]     +1 system test framework.  The patch passed system test framework compile.

These changes represent only a substitution from one API to an equivalent API with better
error handling.  No functionality is intended to change, so the existing suite of unit tests
sufficiently tests the changes.

+1.  I will commit the patch after committing HADOOP-7342.


> Fix all the places where Java method File.list is used with FileUtil.list API
> -----------------------------------------------------------------------------
>
>                 Key: HDFS-2019
>                 URL: https://issues.apache.org/jira/browse/HDFS-2019
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 0.23.0
>            Reporter: Bharath Mundlapudi
>            Assignee: Bharath Mundlapudi
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: HDFS-2019-1.patch
>
>
> This new method FileUtil.list will throw an exception when disk is bad rather than returning
null. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message