hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-1619) Does libhdfs really need to depend on AC_TYPE_INT16_T, AC_TYPE_INT32_T, AC_TYPE_INT64_T and AC_TYPE_UINT16_T ?
Date Sat, 04 Jun 2011 02:46:47 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044173#comment-13044173
] 

Hadoop QA commented on HDFS-1619:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12481427/HDFS-1619.patch.txt
  against trunk revision 1131264.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these core unit tests:
                  org.apache.hadoop.hdfs.TestHDFSTrash

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/706//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/706//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/706//console

This message is automatically generated.

> Does libhdfs really need to depend on AC_TYPE_INT16_T, AC_TYPE_INT32_T, AC_TYPE_INT64_T
and AC_TYPE_UINT16_T ?
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1619
>                 URL: https://issues.apache.org/jira/browse/HDFS-1619
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Roman Shaposhnik
>            Assignee: Konstantin Shvachko
>         Attachments: HDFS-1619.patch.txt
>
>
> Currently configure.ac uses AC_TYPE_INT16_T, AC_TYPE_INT32_T, AC_TYPE_INT64_T and AC_TYPE_UINT16_T
and thus requires autoconf 2.61 or higher. 
> This prevents using it on such platforms as CentOS/RHEL 5.4 and 5.5. Given that those
are pretty popular and also given that it is really difficult to find a platform
> these days that doesn't natively define  intXX_t types I'm curious as to whether we can
simply remove those macros or perhaps fail ONLY if we happen to be on such
> a platform. 
> Here's a link to GNU autoconf docs for your reference:
>     http://www.gnu.org/software/hello/manual/autoconf/Particular-Types.html

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message