hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ivan Kelly (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-2003) Separate FSEditLog reading logic from editLog memory state building logic
Date Tue, 07 Jun 2011 14:02:59 GMT

     [ https://issues.apache.org/jira/browse/HDFS-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ivan Kelly updated HDFS-2003:
-----------------------------

    Attachment: HDFS-2003.diff

Fixed the findbugs. I don't think its worth doing it in another JIRA as the changes for it
are tiny and don't do very much. I commented the code out instead of removing so that it's
clear what was meant to be read. 

The reason this didn't hit before was that timestamp and atime were being reused in FSEditLogLoader#loadEditRecords().

> Separate FSEditLog reading logic from editLog memory state building logic
> -------------------------------------------------------------------------
>
>                 Key: HDFS-2003
>                 URL: https://issues.apache.org/jira/browse/HDFS-2003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: Edit log branch (HDFS-1073)
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: Edit log branch (HDFS-1073)
>
>         Attachments: 2003-delta.txt, HDFS-2003.diff, HDFS-2003.diff, HDFS-2003.diff,
HDFS-2003.diff, HDFS-2003.diff, hdfs-2003.txt, hdfs-2003.txt
>
>
> Currently FSEditLogLoader has code for reading from an InputStream interleaved with code
which updates the FSNameSystem and FSDirectory. This makes it difficult to read an edit log
without having a whole load of other object initialised, which is problematic if you want
to do things like count how many transactions are in a file etc. 
> This patch separates the reading of the stream and the building of the memory state.


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message