hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daryn Sharp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-1788) FsShell ls: Show symlinks properties
Date Thu, 16 Jun 2011 14:45:47 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050465#comment-13050465
] 

Daryn Sharp commented on HDFS-1788:
-----------------------------------

Oh, I'm not disagreeing with adding {{fc}} or {{lstat}}.  I'm just saying leave {{fs}} intact
until we can remove it, ie. have both {{fc}} and {{fs}}.  HDFS appears to lazy-load {{FileStatus}},
but not all {{FileSystem}}s do.  Hence why it makes sense for a {{lstat()}} since very few
commands (cp/mv/ls), in limited cases, will need a stat of the link.  Whereas every command
uses {{stat}}.

Perhaps I'm misunderstanding: why should commands like cat/tail be symlink aware?  In the
normal access case, symlinks should be transparent to a client.  Ie. The filesystem should
be responsible for resolving symlinks.  Very few commands should know or care about a symlink.

Note that HADOOP-7360 is changing a lot of the {{PathData}} ctors to be private.  The fs cannot
be passed in, and that change was in part intended to greatly simplify the move to {{FileContext}}.
 I hope to have this jira approved in the next few days, so I'd recommend waiting to post
another patch until 7360 is integrated.

On a related note to waiting for my patches, please be mindful of working on jiras that are
already assigned.  In the future, please contact an assignee for the status of their work.
 In this case, the assignee of this jira was already working on the change and waiting for
a few of my patches to go in.

> FsShell ls: Show symlinks properties
> ------------------------------------
>
>                 Key: HDFS-1788
>                 URL: https://issues.apache.org/jira/browse/HDFS-1788
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: tools
>            Reporter: Jonathan Eagles
>            Assignee: John George
>            Priority: Minor
>         Attachments: HDFS-1788.patch
>
>
> ls FsShell command implementation has been consistent with the linux implementations
of ls \-l. With the addition of symlinks, I would expect the ability to show file type 'd'
for directory, '\-' for file, and 'l' for symlink. In addition, following the linkname entry
for symlinks, I would expect the ability to show "\-> <link target>". In linux, the
default is to the the properties of the link and not of the link target. In linux, '-L' option
allows for the dereferencing of symlinks to show link target properties, but it is not the
default. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message