hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Foley (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-2061) two minor bugs in BlockManager block report processing
Date Fri, 10 Jun 2011 18:05:59 GMT

     [ https://issues.apache.org/jira/browse/HDFS-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Matt Foley updated HDFS-2061:
-----------------------------

    Attachment: HDFS-2061.patch

addStoredBlock() is not currently robust against future sub-classing of BlockInfoUnderConstruction:
{code}
//currently uses
if (block.getClass() == BlockInfoUnderConstruction.class) {...}
//should be
if (block instanceof BlockInfoUnderConstruction) {...}
{code}

processReportedBlock() had a left-over "this" in an assert message, from being moved from
DatanodeDescriptor to BlockManager:
{code}
//currently uses
... + " in recentInvalidatesSet should not appear in DN " + this;
//should be
... + " in recentInvalidatesSet should not appear in DN " + dn;
{code}


> two minor bugs in BlockManager block report processing
> ------------------------------------------------------
>
>                 Key: HDFS-2061
>                 URL: https://issues.apache.org/jira/browse/HDFS-2061
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.23.0
>            Reporter: Matt Foley
>            Assignee: Matt Foley
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: HDFS-2061.patch
>
>
> In a recent review of HDFS-1295 patches (speedup for block report processing), found
two very minor bugs in BlockManager, as documented in following comments.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message