hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Foley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2011) Removal and restoration of storage directories on checkpointing failure doesn't work properly
Date Tue, 28 Jun 2011 00:01:17 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056216#comment-13056216
] 

Matt Foley commented on HDFS-2011:
----------------------------------

Looking great!  And you're right about needing the iterator to access nnStorage.getEditsDirectories(),
since it's just a Collection.

There's just one small thing I'd like to fix:
* in testSetCheckpointTimeInStorageHandlesIOException, new File ctor, you shouldn't need slashes
around "/storageDirToCheck/", "storageDirToCheck" should work.
* and one trivial edit: The comment in EditLogFileOutputStream.close(), "// if already closed,
just return" isn't correct any more.  "// if already closed, just skip" would be correct.

If that's okay, I'll commit it on the next round.

> Removal and restoration of storage directories on checkpointing failure doesn't work
properly
> ---------------------------------------------------------------------------------------------
>
>                 Key: HDFS-2011
>                 URL: https://issues.apache.org/jira/browse/HDFS-2011
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.23.0
>            Reporter: Ravi Prakash
>            Assignee: Ravi Prakash
>         Attachments: HDFS-2011.3.patch, HDFS-2011.4.patch, HDFS-2011.5.patch, HDFS-2011.6.patch,
HDFS-2011.7.patch, HDFS-2011.patch, HDFS-2011.patch, HDFS-2011.patch
>
>
> Removal and restoration of storage directories on checkpointing failure doesn't work
properly. Sometimes it throws a NullPointerException and sometimes it doesn't take off a failed
storage directory

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message