hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-929) DFSClient#getBlockSize is unused
Date Sat, 25 Jun 2011 21:17:47 GMT

    [ https://issues.apache.org/jira/browse/HDFS-929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054970#comment-13054970
] 

Hadoop QA commented on HDFS-929:
--------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12483825/HDFS-929-take1.txt
  against trunk revision 1139473.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/841//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/841//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/841//console

This message is automatically generated.

> DFSClient#getBlockSize is unused
> --------------------------------
>
>                 Key: HDFS-929
>                 URL: https://issues.apache.org/jira/browse/HDFS-929
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 0.21.0
>            Reporter: Eli Collins
>            Assignee: Jim Plush
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: HDFS-929-take1.txt
>
>
> DFSClient#getBlockSize is unused. Since it's a public class internal to HDFS we just
remove it? If not then we should add a unit test.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message