hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2110) Cleanup StreamFile#sendPartialData
Date Tue, 28 Jun 2011 05:08:17 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056307#comment-13056307

Hadoop QA commented on HDFS-2110:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision 1140030.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/853//console

This message is automatically generated.

> Cleanup StreamFile#sendPartialData
> ----------------------------------
>                 Key: HDFS-2110
>                 URL: https://issues.apache.org/jira/browse/HDFS-2110
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>             Fix For: 0.23.0
>         Attachments: hdfs-2110-1.patch, hdfs-2110-2.patch
> StreamFile#sendPartialData can be cleaned up, has some System.out.printlns, no javadoc,
and the byte copying method should be pulled out to IOUtils. 

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message