Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Tue, 17 May 2011 05:11:47 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <986124152.18029.1305609107421.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <872511945.8686.1305245447368.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-1932) Add utility method to initialize
 HDFS default configurations
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034559#comment-13034559 ] 

Hadoop QA commented on HDFS-1932:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12479285/hdfs-1932-2.txt
  against trunk revision 1103987.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these core unit tests:
                  org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
                  org.apache.hadoop.hdfs.TestFileConcurrentReader
                  org.apache.hadoop.tools.TestJMXGet

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/533//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/533//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/533//console

This message is automatically generated.

> Add utility method to initialize HDFS default configurations
> ------------------------------------------------------------
>
>                 Key: HDFS-1932
>                 URL: https://issues.apache.org/jira/browse/HDFS-1932
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Jolly Chen
>            Priority: Critical
>              Labels: newbie
>         Attachments: hdfs-1932-2.txt, hdfs-1932.txt
>
>
> Currently we have code blocks like the following in lots of places:
> {code}
>   static{
>     Configuration.addDefaultResource("hdfs-default.xml");
>     Configuration.addDefaultResource("hdfs-site.xml");
>   }
> {code}
> This is dangerous since, if we don't remember to also classload HdfsConfiguration, the config key deprecations won't work. We should add a method like HdfsConfiguration.init() which would load the default resources as well as ensure that deprecation gets initialized properly.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira