Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CD3A1542E for ; Thu, 12 May 2011 14:50:30 +0000 (UTC) Received: (qmail 32649 invoked by uid 500); 12 May 2011 14:50:30 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 32608 invoked by uid 500); 12 May 2011 14:50:30 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 32600 invoked by uid 99); 12 May 2011 14:50:30 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 May 2011 14:50:30 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 May 2011 14:50:26 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 5D0D08732E for ; Thu, 12 May 2011 14:49:47 +0000 (UTC) Date: Thu, 12 May 2011 14:49:47 +0000 (UTC) From: "Hadoop QA (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <579098021.6886.1305211787377.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <46765173.6819.1305210227754.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HDFS-1926) Remove references to StorageDirectory from JournalManager interface MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032439#comment-13032439 ] Hadoop QA commented on HDFS-1926: --------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478972/HDFS-1926.diff against trunk revision 1102153. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2511 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/498//console This message is automatically generated. > Remove references to StorageDirectory from JournalManager interface > ------------------------------------------------------------------- > > Key: HDFS-1926 > URL: https://issues.apache.org/jira/browse/HDFS-1926 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Ivan Kelly > Assignee: Ivan Kelly > Attachments: HDFS-1926.diff > > > The JournalManager interface introduced by HDFS-1799 has a getStorageDirectory method which is out of place in a generic interface. This JIRA removed that call by refactoring the error handling for FSEditLog. Each EditLogFileOutputStream is now a NNStorageListener and listens for error on it's containing StorageDirectory. If an error occurs from FSImage, the stream will be aborted. If the error occurs in FSEditLog, the stream will be aborted and NNStorage will be notified that the StorageDirectory is no longer valid. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira