Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B834F4274 for ; Fri, 13 May 2011 21:47:29 +0000 (UTC) Received: (qmail 44574 invoked by uid 500); 13 May 2011 21:47:29 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 44528 invoked by uid 500); 13 May 2011 21:47:29 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 44520 invoked by uid 99); 13 May 2011 21:47:29 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 May 2011 21:47:29 +0000 X-ASF-Spam-Status: No, hits=-1996.4 required=5.0 tests=ALL_TRUSTED,FS_REPLICA,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 May 2011 21:47:27 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 6CAF089D1D for ; Fri, 13 May 2011 21:46:47 +0000 (UTC) Date: Fri, 13 May 2011 21:46:47 +0000 (UTC) From: "Tsz Wo (Nicholas), SZE (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <349913005.11585.1305323207442.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HDFS-1332) When unable to place replicas, BlockPlacementPolicy should log reasons nodes were excluded MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13033324#comment-13033324 ] Tsz Wo (Nicholas), SZE commented on HDFS-1332: ---------------------------------------------- >From the summary and description, I think this is about log messages. So my suggestion is (c) If {{BlockPlacementPolicy.LOG.isDebugEnabled()}}, construct a log message and then print it before throwing the exception. Otherwise, no HashMap nor strings should be created. > When unable to place replicas, BlockPlacementPolicy should log reasons nodes were excluded > ------------------------------------------------------------------------------------------ > > Key: HDFS-1332 > URL: https://issues.apache.org/jira/browse/HDFS-1332 > Project: Hadoop HDFS > Issue Type: Improvement > Components: name-node > Reporter: Todd Lipcon > Assignee: Ted Yu > Priority: Minor > Labels: newbie > Fix For: 0.23.0 > > Attachments: HDFS-1332.patch > > > Whenever the block placement policy determines that a node is not a "good target" it could add the reason for exclusion to a list, and then when we log "Not able to place enough replicas" we could say why each node was refused. This would help new users who are having issues on pseudo-distributed (eg because their data dir is on /tmp and /tmp is full). Right now it's very difficult to figure out the issue. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira