Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Tue, 3 May 2011 09:23:03 +0000 (UTC)
From: "Eli Collins (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <307200525.18047.1304414583436.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1148888743.26876.1301636285841.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-1799) Refactor log rolling and filename
 management out of FSEditLog
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028122#comment-13028122 ] 

Eli Collins commented on HDFS-1799:
-----------------------------------

bq. More code changes and more classes indicate that more complexity is being added

Sometimes additional classes add complexity and sometimes they reduce it. In any case, HDFS-1580 also adds an additional class here so that point seems mute. Let's not make interface design decisions with the justification that the overhead of keeping some extra object instances around for the life time of FSEditLog. It's not like we're creating a thousand of these. Seems like premature optimization. Do you think the code and data for managing the lifecycle of logs/ledgers should not be logically grouped?

bq. I really don't like the call to getCurrentStream() having to be called every time you want an output stream. 

Why? Can you be more specific?

> Refactor log rolling and filename management out of FSEditLog
> -------------------------------------------------------------
>
>                 Key: HDFS-1799
>                 URL: https://issues.apache.org/jira/browse/HDFS-1799
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: Edit log branch (HDFS-1073)
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: Edit log branch (HDFS-1073)
>
>         Attachments: 0001-Added-state-management-to-FSEditLog.patch, 0002-Standardised-error-pattern.patch, 0003-Add-JournalFactory-and-move-divert-revert-out-of-FSE.patch, HDFS-1799-all.diff, hdfs-1799.txt, hdfs-1799.txt, hdfs-1799.txt, hdfs-1799.txt
>
>
> This is somewhat similar to HDFS-1580, but less ambitious. While that JIRA focuses on pluggability, this task is simply the minimum needed for HDFS-1073:
> - Refactor the filename-specific code for rolling, diverting, and reverting log streams out of FSEditLog into a new class
> - Clean up the related code in FSEditLog a bit
> Notably, this JIRA is going to temporarily break the BackupNode. I plan to circle back on the BackupNode later on this branch.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira