Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0E51E4D2D for ; Fri, 27 May 2011 20:45:31 +0000 (UTC) Received: (qmail 11620 invoked by uid 500); 27 May 2011 20:45:30 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 11590 invoked by uid 500); 27 May 2011 20:45:30 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 11559 invoked by uid 99); 27 May 2011 20:45:30 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 May 2011 20:45:30 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 May 2011 20:45:28 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 99442E3580 for ; Fri, 27 May 2011 20:44:47 +0000 (UTC) Date: Fri, 27 May 2011 20:44:47 +0000 (UTC) From: "Todd Lipcon (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <1915593855.49777.1306529087624.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1601286575.41154.1306286327499.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Resolved] (HDFS-1994) Fix race conditions when running two rapidly checkpointing 2NNs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon resolved HDFS-1994. ------------------------------- Resolution: Fixed Hadoop Flags: [Reviewed] Fixed the nits and committed to branch. Unfortunately Mockito doesn't provide that Answer implementation, but I based that implementation on a suggestion I found on the Mockito bugtracker. > Fix race conditions when running two rapidly checkpointing 2NNs > --------------------------------------------------------------- > > Key: HDFS-1994 > URL: https://issues.apache.org/jira/browse/HDFS-1994 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node > Affects Versions: Edit log branch (HDFS-1073) > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Fix For: Edit log branch (HDFS-1073) > > Attachments: hdfs-1994.txt, hdfs-1994.txt > > > HDFS-1984 added the ability to run two secondary namenodes at the same time. However, there were two races I found when stress testing this (by running two NNs each checkpointing in a tight loop with no sleep): > 1) the writing of the seen_txid file was not atomic, so it was at some points reading an empty file > 2) it was possible for two checkpointers to try to take a checkpoint at the same transaction ID, which would cause the two image downloads to collide and fail -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira