Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A84A14D94 for ; Fri, 13 May 2011 18:52:27 +0000 (UTC) Received: (qmail 59028 invoked by uid 500); 13 May 2011 18:52:27 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 58987 invoked by uid 500); 13 May 2011 18:52:27 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 58979 invoked by uid 99); 13 May 2011 18:52:27 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 May 2011 18:52:27 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 May 2011 18:52:26 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 94ACD89A0A for ; Fri, 13 May 2011 18:51:47 +0000 (UTC) Date: Fri, 13 May 2011 18:51:47 +0000 (UTC) From: "Todd Lipcon (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <1617861309.10936.1305312707605.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <253221858.8780.1305248207356.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HDFS-1933) Update tests for FsShell's "test" MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13033205#comment-13033205 ] Todd Lipcon commented on HDFS-1933: ----------------------------------- In the tests, why do we need the try..catch around all of the invocations? It seems to me that we don't expect anything to be thrown, so we should just let the exception out so it will fail the test if thrown. > Update tests for FsShell's "test" > --------------------------------- > > Key: HDFS-1933 > URL: https://issues.apache.org/jira/browse/HDFS-1933 > Project: Hadoop HDFS > Issue Type: Test > Components: test > Affects Versions: 0.23.0 > Reporter: Daryn Sharp > Assignee: Daryn Sharp > Attachments: HDFS-1933.patch > > > Fix tests broken by refactoring. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira